remove custom __repr__ from prototype features #5916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know if this affects #5558 ? |
Yeah I also checked, but unfortunately no. I think the issue there depends on how we add methods onto tensors. |
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 6, 2022
Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095690 fbshipit-source-id: 9567c53d9b9c2ba4094a1d9166b45fb75d6affa0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amongst other things, pytorch/pytorch#73459 added support to automatically include the name of the tensor subclass in the
__repr__. Thus, we no longer need to do this ourselves.The same PR also changed the signature of
Tensor.__repr__which lead tomypyerrors.