Validate against expected files on videos #6077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdsgomes
approved these changes
May 24, 2022
NicolasHug
approved these changes
May 24, 2022
|
@NicolasHug They are fast, like few seconds on my machine. This PR should not increase the execution time. For some reason, we used to execute all the expensive parts of the tests such as producing predictions and jit-scripting but we didn't compare the output against expected files. Not sure what was the decision behind this but as I'm adding a new model I want to make sure I wont accidentally break the implementation. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Summary: * Validate against expected files on videos * Plus tests for autocast Reviewed By: NicolasHug Differential Revision: D36760920 fbshipit-source-id: c9601c794b9b4ea8ad7c00641b8c4fbfb1d0725c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds similar tests to the video classification models as the ones we have for images.