Skip to content

Change weights return type to Mapping #6097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2022
Merged

Change weights return type to Mapping #6097

merged 2 commits into from
May 26, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented May 26, 2022 •
edited
Loading

As of recently, PyTorch Core's switched its types to the following signature:

    def load_state_dict(self, state_dict: Mapping[str, Any],
                        strict: bool = True):

This PR aligns with it.

@datumbox datumbox mentioned this pull request May 26, 2022
Closed
@datumbox datumbox requested a review from YosuaMichael May 26, 2022 11:51
YosuaMichael
YosuaMichael approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@YosuaMichael YosuaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@datumbox datumbox merged commit 6aaa2b0 into pytorch:main May 26, 2022
@datumbox datumbox deleted the dict_to_mapping branch May 26, 2022 13:19
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
@YosuaMichael @facebook-github-bot
[fbsync] Change weights return type to Mapping (#6097)
3f28438 
Reviewed By: NicolasHug

Differential Revision: D36760951

fbshipit-source-id: 4098becffda7fdf4b987f2ca2ed882f914cde40f
@frgfm frgfm mentioned this pull request Oct 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YosuaMichael YosuaMichael YosuaMichael approved these changes

Assignees
No one assigned
Labels
cla signed code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @YosuaMichael @facebook-github-bot