Put back CelebA download #6147
Merged
Put back CelebA download #6147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removed (pytorch#6059)" This reverts commit 49496c4.
This reverts commit ac56f52.
datumbox
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
LGTM, thanks @NicolasHug. Do you intent to cherrypick this in the release?
Edit: yes you do. Github didn't show me the tagging on the Release Tracker.
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Jun 9, 2022
* Revert "Indicate Celeba download parameter is deprecated and will be removed (pytorch#6059)" This reverts commit 49496c4. * Revert "Deactivate CelebA download (pytorch#6052)" This reverts commit ac56f52.
NicolasHug
added
revert(ed)
datumbox
pushed a commit
that referenced
this pull request
Jun 10, 2022
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Jun 16, 2022
Summary: * Revert "Indicate Celeba download parameter is deprecated and will be removed (pytorch#6059)" This reverts commit 49496c4. * Revert "Deactivate CelebA download (pytorch#6052)" This reverts commit ac56f52. Differential Revision: D37212658 fbshipit-source-id: 608b722a2b96317a1daf97623679a4a1b2c1f14d
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
Summary: * Revert "Indicate Celeba download parameter is deprecated and will be removed (#6059)" This reverts commit 49496c4. * Revert "Deactivate CelebA download (#6052)" This reverts commit ac56f52. Reviewed By: datumbox Differential Revision: D37212658 fbshipit-source-id: 756061b60ed3954b7ff4422b0413ec0ed6a4e932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #6059 and #6052 since CelebA can now be downloaded properly.