[proto] Draft for Transforms API v2 #6205
Conversation
- Added H/V flip ops - Added resize op - Added center_crop
Other nits
…ision into proto-transforms-api-oo
| # Just output itself | ||
| # How dangerous to do this instead of raising an error ? | ||
| return self |
There was a problem hiding this comment.
I would raise a "not implemented" error here and implement no-op explicitly on the implementations. So if bbox can't blur, then it should explicitly implement to be no-op as opposed to leaving the default implementation which returns self. Could help us avoid issues but if you disagree I'm happy to leave as-is and discuss later.
There was a problem hiding this comment.
I agree that raising NotImplemented could be good. The only drawback I found that all targets features like Label, OneHotLabel should also implement explicitly these no-ops. From the first glance, implementing all methods like OneHotLabel.blur(self, *args, **kwargs) as no-op made me think that it is a bit too much...
There was a problem hiding this comment.
Up to you. I've added this for your consideration. Feel free to ignore or postpone for later.
|
Closed in favor of #6305 |
A draft for Transforms API v2