Add FallingThings dataset #6346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Thanks @TeodorPoncu , minor comments from me but LGTM anyway
| transforms (callable, optional): A function/transform that takes in a sample and returns a transformed version. | ||
| """ | ||
|
|
||
| def __init__(self, root: str, variant: str = "single", transforms: Optional[Callable] = None): |
There was a problem hiding this comment.
Just trying to figure out whether there are relevant alternatives for "variant" here. Looking at the authors' README I could only find "scene type".
At the root level, there are two folders representing the two types of scenes:
single(single falling object), andmixed(2 to 10 falling objects).
Not sure it's better though...
There was a problem hiding this comment.
I've got no particular feelings about this, it's definitely not a "split" therefor I just opted for "variant" to keep consistent with other datasets.
Changed constant formatting Co-authored-by: Nicolas Hug <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
Summary: * Added Falling Things datasets * Renamed split to variant * Update torchvision/datasets/_stereo_matching.py Changed constant formatting Reviewed By: datumbox Differential Revision: D38824218 fbshipit-source-id: adeeeec057bd0afd1fb286e11526b871e62d376f Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the PR split (#6311, #6269) which contains the FallingThings dataset variants.