-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Add Sintel Stereo dataset #6348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c057189
added SceneFLow variant datasets
TeodorPoncu 996df9b
Changed split name to variant name
TeodorPoncu 9f85dc1
removed trailing commented code line
TeodorPoncu c5a154d
Added Sintel Stereo dataset
TeodorPoncu 95db561
small refactor in tests
TeodorPoncu 43c41af
Fixed doc formatting.
TeodorPoncu 1f2c72e
candidate fix for FileNotFound on windows test
TeodorPoncu 633e50b
Adressing comments
TeodorPoncu 62bbe44
Merge branch 'main' into add-stereo-flyingthings
TeodorPoncu a3c6cb9
Merge branch 'main' into add-sintel-stereo-dataset
TeodorPoncu 35eba77
Added Sintel Stereo dataset
TeodorPoncu 7f3f32a
small refactor in tests
TeodorPoncu 78a5f2d
Fixed doc formatting.
TeodorPoncu 4cc28cb
candidate fix for FileNotFound on windows test
TeodorPoncu 5138c56
Adressing comments
TeodorPoncu 34b262c
rebased on main
TeodorPoncu d84b0ec
Merge branch 'add-sintel-stereo-dataset' of https://github.com/pytorc…
TeodorPoncu 17bd858
Merge branch 'main' into add-sintel-stereo-dataset
TeodorPoncu 7dc5399
Merge branch 'main' into add-sintel-stereo-dataset
TeodorPoncu 70681aa
Merge branch 'main' into add-sintel-stereo-dataset
TeodorPoncu e144f48
lint fix
TeodorPoncu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,6 +111,7 @@ Stereo Matching | |
| CarlaStereo | ||
| Kitti2012Stereo | ||
| Kitti2015Stereo | ||
| SintelStereo | ||
|
|
||
| Image pairs | ||
| ~~~~~~~~~~~ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,5 @@ | ||||||
| import functools | ||||||
| import os | ||||||
| from abc import ABC, abstractmethod | ||||||
| from glob import glob | ||||||
| from pathlib import Path | ||||||
|
|
@@ -359,3 +360,125 @@ def __getitem__(self, index: int) -> Tuple: | |||||
| Both ``disparity`` and ``valid_mask`` are ``None`` if the dataset split is test. | ||||||
| """ | ||||||
| return super().__getitem__(index) | ||||||
|
|
||||||
|
|
||||||
| class SintelStereo(StereoMatchingDataset): | ||||||
| """ "Sintel `Stereo Dataset <http://sintel.is.tue.mpg.de/stereo>`_. | ||||||
|
||||||
| """ "Sintel `Stereo Dataset <http://sintel.is.tue.mpg.de/stereo>`_. | |
| """Sintel `Stereo Dataset <http://sintel.is.tue.mpg.de/stereo>`_. |
Outdated
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| pass_name (string): The name of the pass to use, either "final" or "clean". | |
| pass_name (string): The name of the pass to use, either "final", "clean", or "both". |
Outdated
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, typo
Suggested change
| occlued_mask_path, out_of_frame_mask_path = self._get_oclussion_mask_paths(file_path) | |
| occluded_mask_path, out_of_frame_mask_path = self._get_occlussion_mask_paths(file_path) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure the logic is picked up on