Added Middlebury2014 dataset #6350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdsgomes
approved these changes
Aug 19, 2022
test/test_datasets.py
Outdated
| datasets_utils.create_image_file(root=scene_dir, name="im1E.png", size=(3, 100, 100)) | ||
| datasets_utils.create_image_file(root=scene_dir, name="im1L.png", size=(3, 100, 100)) | ||
| # these are going to end up being gray scale images | ||
| datasets_utils.make_fake_pfm_file(h=100, w=100, file_name=os.path.join(scene_dir, "disp0.pfm")) |
There was a problem hiding this comment.
Nit: You can use scene_dir / fname here and in the line bellow to be more consistent with the rest of the PR
| scene_url = f"{base_url}/{scene_name}.zip" | ||
| print(f"Downloading {scene_url}") | ||
| # download the scene only if it doesn't exist | ||
| if not os.path.exists(split_root / scene_name): |
There was a problem hiding this comment.
Another nit: you can just use exists from pathlib: (solit_root / scene_name).exists()
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
Summary: * Added Middlebury2014 dataset * adressed nits * mypy fix Reviewed By: YosuaMichael Differential Revision: D39426991 fbshipit-source-id: 382a30aee1b4927a5cb47a338f2307ec3241bb71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the PR split (#6311, #6269) which contains the Middlebury 2014 version dataset.