Skip to content

Fix minor bug on PolynomialLR invocation #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix minor bug on PolynomialLR invocation #6436

merged 1 commit into from
Aug 17, 2022

Conversation

datumbox
Copy link
Contributor

Resolves issue reported at 6e535db#commitcomment-81409388

There seems to be a misspelling on the name of the parameter. This PR updates total_steps to total_iters which is the correct argument.

Resolves issue reported at 6e535db#commitcomment-81409388

There seems to be a misspelling on the name of the parameter. This PR updates `total_steps` to `total_iters` which is the correct argument.
Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@datumbox datumbox merged commit 78d680f into main Aug 17, 2022
@datumbox datumbox deleted the datumbox-patch-1 branch August 17, 2022 11:48
facebook-github-bot pushed a commit that referenced this pull request Aug 24, 2022
Summary:
Resolves issue reported at 6e535db#commitcomment-81409388

There seems to be a misspelling on the name of the parameter. This PR updates `total_steps` to `total_iters` which is the correct argument.

Reviewed By: datumbox

Differential Revision: D38824253

fbshipit-source-id: 08401f694398a8c64e198bfc16fed874f5c7b462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants