reinstate _split_alpha #6838
Closed
reinstate _split_alpha #6838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
reviewed
Oct 26, 2022
| def _split_alpha(image: torch.Tensor) -> List[torch.Tensor]: | ||
| return torch.tensor_split(image, indices=(-1,), dim=-3) | ||
|
|
||
|
|
||
| def _strip_alpha(image: torch.Tensor) -> torch.Tensor: | ||
| image, alpha = torch.tensor_split(image, indices=(-1,), dim=-3) |
There was a problem hiding this comment.
I think you missed it here.
Comment on lines
+186
to
+187
| def _split_alpha(image: torch.Tensor) -> List[torch.Tensor]: | ||
| return torch.tensor_split(image, indices=(-1,), dim=-3) |
There was a problem hiding this comment.
Frankly I reluctantly agreed with this to unblock the other PR. IMO there is very little value having a private method that does a one liner for an existing method on Core. I don't really mind this, I just think of this from the perspective of our practices. IMO the idiom of:
image, alpha = torch.tensor_split(image, indices=(-1,), dim=-3)
already sufficiently shows that we split the image and the alpha channel. The additional one liner, wrapper method doesn't add anything to the readability of the code. From that perspective, my preference is not to merge this, but I'm not going to insist if this is important to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6832 (comment). Instead of following the potential solution there, which I agree would not be worth it, this PR simply changes the annotation of
_split_alphafromTuple[torch.Tensor, torch.Tensor]toList[torch.Tensor]. Bothmypyand JIT are happy with that.@datumbox I brought this PR because you initially agreed to keep
_split_alphaand apparently the issue above is the thing that tipped you in the other direction. Feel free to close this PR if there is anything else why you prefer the current solution over_split_alpha.cc @vfdev-5 @datumbox @bjuncek