Added typing annotations to datasets/_optical_flow #6845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
NicolasHug
reviewed
Oct 27, 2022
pmeier
previously approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Thanks Francois, LGTM! One question though that is more directed at @NicolasHug: given that we are talking mostly about private methods here, is there a benefit of allowing Union[str, pathlib.Path] over a plain Path or str?
frgfm
requested review from
pmeier and
NicolasHug
and removed request for
pmeier and
NicolasHug
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
Summary: * style: Added typing annotations to datasets/_optical_flow * style: Reverted back to str typing Reviewed By: YosuaMichael Differential Revision: D42046594 fbshipit-source-id: 0a6b4720602a2bd83457733824205f66839ae2c1 Co-authored-by: Philip Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2025, this PR adds typing annotations in models/datasets/_optical_flow
Any feedback is welcome!
cc @datumbox @pmeier @oke-aditya