Merged
Conversation
pmeier
approved these changes
Nov 14, 2022
Contributor
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM if CI is green. Thanks Vasilis!
|
|
||
| def crop_mask(mask: torch.Tensor, top: int, left: int, height: int, width: int) -> torch.Tensor: | ||
| return crop_image_tensor(mask, top, left, height, width) | ||
| if mask.ndim < 3: |
Contributor
There was a problem hiding this comment.
We need this handling here, because _pad_with_scalar_fill doesn't support 2d images, right? Otherwise, I don't see anything in crop_image_tensor that would require 3 or more dims.
Contributor
Author
There was a problem hiding this comment.
Correct. The issue come from pad:
File "./vision/torchvision/prototype/transforms/functional/_geometry.py", line 890, in _pad_with_scalar_fill
num_channels, height, width = shape[-3:]
31 tasks
Contributor
Author
|
The following failing test is unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originally found at #6945, I split the work to reduce complexity on the other PR.
We address comments:
cc @vfdev-5 @bjuncek @pmeier