Skip to content

allow subclasses in dataset wrappers #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 14, 2023
Merged

allow subclasses in dataset wrappers #7236

merged 10 commits into from
Feb 14, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 13, 2023 •
edited by pytorch-bot bot
Loading

@pmeier pmeier mentioned this pull request Feb 13, 2023
Closed
49 tasks
NicolasHug
NicolasHug approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but still LGTM

@NicolasHug NicolasHug merged commit d744da9 into pytorch:main Feb 14, 2023
@pmeier pmeier deleted the dataset-wrappers-subclasses branch February 14, 2023 10:21
facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2023
@NicolasHug @facebook-github-bot
[fbsync] allow subclasses in dataset wrappers (#7236)
1283673 
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens

Differential Revision: D44416624

fbshipit-source-id: 0f0e79e176e256b9749bf0e13492034122b388fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: datasets module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot