Promote prototype transforms to beta status #7261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto migration_transforms_v2
…vision into migration_transforms_v2
vfdev-5
reviewed
Feb 15, 2023
| @@ -1089,12 +1089,18 @@ def make_datapoints(self, with_mask=True): | |||
| "t_ref, t, data_kwargs", | |||
| [ | |||
| (det_transforms.RandomHorizontalFlip(p=1.0), prototype_transforms.RandomHorizontalFlip(p=1.0), {}), | |||
| (det_transforms.RandomIoUCrop(), prototype_transforms.RandomIoUCrop(), {"with_mask": False}), | |||
| # FIXME: make | |||
There was a problem hiding this comment.
@pmeier what's broken here ?
There was a problem hiding this comment.
After removing the Label and OneHotLabel classes, RandomIoUCrop no longer removes labels since it doesn't have a notion of them. To resolve this, we need to follow my suggestion in the comment and use a composed transform with RandomIoUCrop and the new SanitizeBoundingBoxes that @NicolasHug implemented.
NicolasHug
approved these changes
Feb 16, 2023
|
Failed tests are related: https://github.com/pytorch/vision/actions/runs/4188549423/jobs/7259827006 ? |
|
Yes. Will fix them. |
|
Relevant CI is green. Let's do this 🎉 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
Summary: Reviewed By: vmoens Differential Revision: D44416605 fbshipit-source-id: 0fd313c8279f6be9ed488a19e2d053f33c2f77a5 Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: vfdev-5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @vfdev-5 @bjuncek