Skip to content

reduce GHA log output #7267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2023
Merged

reduce GHA log output #7267

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5adb66
reduce GHA log output
pmeier Feb 16, 2023
bff4f53
Merge branch 'main' into gha-ci
pmeier Feb 22, 2023
803a6d6
Apply suggestions from code review
pmeier Feb 22, 2023
e39a333
cleanup
pmeier Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test-linux-cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
fi

# Create Conda Env
conda create -yp ci_env python="${PYTHON_VERSION}" numpy libpng jpeg scipy
conda create -yp ci_env --quiet python="${PYTHON_VERSION}" numpy libpng jpeg scipy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to be very frustrating when we have env issues. So... once a week?
😔😔😔😔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects the progress bar:

$ conda create --help | grep -e --quiet
  -q, --quiet           Do not display progress bar.

The actual information about the environment, i.e what is installed / upgraded / downgraded is still there: https://github.com/pytorch/vision/actions/runs/4194550278/jobs/7272863693#step:10:168

conda activate /work/ci_env

# Install PyTorch, Torchvision, and testing libraries
Expand All @@ -50,8 +50,8 @@ jobs:
-c nvidia "pytorch-${CHANNEL}"::pytorch[build="*${VERSION}*"] \
"${CUDATOOLKIT}"
python3 setup.py develop
python3 -m pip install pytest pytest-mock 'av<10'
python3 -m pip install --progress-bar=off pytest pytest-mock 'av<10'

# Run Tests
python3 -m torch.utils.collect_env
python3 -m pytest --junitxml=test-results/junit.xml -v --durations 20
python3 -m pytest --junitxml=test-results/junit.xml --durations 20
6 changes: 3 additions & 3 deletions .github/workflows/test-linux-gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
fi

# Create Conda Env
conda create -yp ci_env python="${PYTHON_VERSION}" numpy libpng jpeg scipy
conda create -yp ci_env --quiet python="${PYTHON_VERSION}" numpy libpng jpeg scipy
conda activate /work/ci_env

# Install PyTorch, Torchvision, and testing libraries
Expand All @@ -54,8 +54,8 @@ jobs:
-c nvidia "pytorch-${CHANNEL}"::pytorch[build="*${VERSION}*"] \
"${CUDATOOLKIT}"
python3 setup.py develop
python3 -m pip install pytest pytest-mock 'av<10'
python3 -m pip install --progress-bar=off pytest pytest-mock 'av<10'

# Run Tests
python3 -m torch.utils.collect_env
python3 -m pytest --junitxml=test-results/junit.xml -v --durations 20
python3 -m pytest --junitxml=test-results/junit.xml --durations 20