-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Deprecate functional_pil and functional_tensor and make them private #7269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And sadly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @NicolasHug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green. Thanks Nicolas!
Thanks for the reviews, failures are unrelated, merging |
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
… private (#7269) Reviewed By: vmoens Differential Revision: D44416620 fbshipit-source-id: 37a242f4ed899e847b7395700650ced038fb3f0b
At this line of code: from pytorchvideo.transforms import (ApplyTransformToKey, Normalize,UniformTemporalSubsample) I am getting ModuleNotFoundError: No module named 'torchvision.transforms.functional_tensor' how can I solve this after this depreciation? |
@Ahmaddimran TorchVision Version Issue: Use a version below 0.17, or modify the |
facing same issue |
python -m pip install torch==2.0.1 torchvision==0.15.2 --extra-index-url https://download.pytorch.org/whl/cu118 |
This PR moves
functional_pil.py
into_functional_pil.py
and letfunctional_pil.py
have the same content (ish), with a warning.The changes are made for
functional_tensor.py
.These changes are hard to test because if we want to make sure all scenarios raise the proper warning, we need multiple executions of the Python interpreter. This can be done via utils like this one form scikit-learn which is used like this.
I... can't be arsed to go through that right now. If you have a better idea, LMK :)
As manual check, all those blocks below properly raise the warning:
cc @vfdev-5