Make rotate_image_tensor's results fully BC with v1#7271
Merged
NicolasHug merged 1 commit intopytorch:mainfrom Feb 16, 2023
Merged
Make rotate_image_tensor's results fully BC with v1#7271NicolasHug merged 1 commit intopytorch:mainfrom
NicolasHug merged 1 commit intopytorch:mainfrom
Conversation
vfdev-5
approved these changes
Feb 16, 2023
Contributor
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Sounds good, thanks @NicolasHug !
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
Reviewed By: vmoens Differential Revision: D44416610 fbshipit-source-id: 94919a1f3cad30bb0f14945ef47d1c776f2359dc
This was referenced Jul 3, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses https://github.com/pytorch/vision/pull/7159/files#r1108677361
I can confirm that all the tests that were failing in #7159 are now passing properly even with
expand=True.cc @vfdev-5 @bjuncek @pmeier