Skip to content

enable Windows CPU CI on GHA #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Apr 4, 2023
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
756cb5c
add minimal windows CI
pmeier Mar 30, 2023
4a3a49c
[REVERTME] disable unrelated CI
pmeier Mar 30, 2023
04398de
fix
pmeier Mar 30, 2023
4133cdc
move debug to actual script
pmeier Mar 30, 2023
a5d0821
try conda first
pmeier Mar 30, 2023
632fceb
try fixing path manually
pmeier Mar 30, 2023
5282b45
trigger CI
pmeier Mar 30, 2023
270638a
try install third party dependencies prior to TorchVision install
pmeier Mar 30, 2023
b792e1d
expand matrix
pmeier Mar 30, 2023
83cea1a
add comments
pmeier Mar 30, 2023
e8b0651
Merge branch 'main' into win-ci
pmeier Mar 30, 2023
53a1c37
fix indent
pmeier Mar 30, 2023
59b5562
fix python invocation
pmeier Mar 30, 2023
4cea941
remove grouping around unit tests
pmeier Mar 30, 2023
4bee1f2
switch to CUDA 11.8
pmeier Mar 30, 2023
bbf58cd
set CUDA_HOME and CUDA_PATH
pmeier Mar 30, 2023
80e3605
only set paths for CUDA runners
pmeier Mar 30, 2023
751d76a
FIXME -> TODO
pmeier Mar 30, 2023
44b1c0b
try use windows style path
pmeier Mar 31, 2023
c585d29
[REVERTME] only run smoke tests
pmeier Mar 31, 2023
3788c01
use bash echo mode
pmeier Mar 31, 2023
a4cdf02
Revert "try use windows style path"
pmeier Mar 31, 2023
359559a
[REVERTME] disable cpu runs
pmeier Mar 31, 2023
d72ee77
fix CUDA path
pmeier Mar 31, 2023
3598511
cleanup conda activation
pmeier Mar 31, 2023
08dfc12
Revert "[REVERTME] disable cpu runs"
pmeier Mar 31, 2023
179c214
Revert "[REVERTME] only run smoke tests"
pmeier Mar 31, 2023
0ff9f51
automate apriori requirement installation
pmeier Mar 31, 2023
7227ae2
Merge branch 'main' into win-ci
pmeier Mar 31, 2023
05dbfb3
move requirement installation just before regular one
pmeier Mar 31, 2023
3e5719b
fix requirement install
pmeier Mar 31, 2023
6d06970
trigger CI
pmeier Apr 3, 2023
c9b3727
[REVERTME] disable CPU workflows
pmeier Apr 3, 2023
c70d95e
Merge branch 'win-ci' of https://github.com/pmeier/vision into win-ci
pmeier Apr 3, 2023
a846096
add check for nvjpeg for CUDA jobs
pmeier Apr 3, 2023
26838ed
Revert "[REVERTME] disable CPU workflows"
pmeier Apr 3, 2023
a5a400a
Revert "[REVERTME] disable unrelated CI"
pmeier Apr 3, 2023
4714a7f
disable GPU tests for now
pmeier Apr 3, 2023
8ae0b19
Merge branch 'main' into win-ci
pmeier Apr 3, 2023
bd94248
try install nvjpeg from conda
pmeier Apr 3, 2023
d4c551d
Merge branch 'win-ci' of https://github.com/pmeier/vision into win-ci
pmeier Apr 3, 2023
1c13a08
enable GPU job
pmeier Apr 3, 2023
866040e
Revert "enable GPU job"
pmeier Apr 4, 2023
c5c129f
remove conda install of nvjpeg
pmeier Apr 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,399 changes: 0 additions & 1,399 deletions .circleci/config.yml

This file was deleted.

21 changes: 17 additions & 4 deletions .github/scripts/setup-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,26 @@ case $(uname) in
Darwin)
OS_TYPE=macos
;;
MSYS*)
OS_TYPE=windows
;;
*)
echo "Unknown OS type:" $(uname)
exit 1
;;
esac

echo '::group::Uninstall system JPEG libraries on macOS'
# The x86 macOS runners, e.g. the GitHub Actions native "macos-12" runner, has some JPEG libraries installed by default
# that interfere with our build. We uninstall them here and use the one from conda below.
if [[ "${OS_TYPE}" == "macos" && $(uname -m) == x86_64 ]]; then
echo '::group::Uninstall system JPEG libraries on macOS'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just moves the grouping inside the if so this doesn't show up empty on non-macos runners.

# The x86 macOS runners, e.g. the GitHub Actions native "macos-12" runner, has some JPEG libraries installed by
# default that interfere with our build. We uninstall them here and use the one from conda below.
JPEG_LIBS=$(brew list | grep jpeg)
echo $JPEG_LIBS
for lib in $JPEG_LIBS; do
brew uninstall --ignore-dependencies --force $lib || true
done
echo '::endgroup::'
fi
echo '::endgroup::'

echo '::group::Create build environment'
# See https://github.com/pytorch/vision/issues/7296 for ffmpeg
Expand All @@ -51,6 +54,16 @@ fi

echo '::endgroup::'

if [[ "${OS_TYPE}" == "windows" ]]; then
echo '::group::Install third party dependencies prior to TorchVision install on Windows'
# `easy_install`, i.e. `python setup.py` has problems downloading the dependencies due to SSL.
# Thus, we install them upfront with `pip` to avoid that.
# Instead of fixing the SSL error, we can probably maintain this special case until we switch away from the deprecated
# `easy_install` anyway.
pip install --progress-bar=off 'Pillow>=5.3.0,!=8.3.*' numpy requests
echo '::endgroup::'
fi

echo '::group::Install PyTorch'
# TODO: Can we maybe have this as environment variable in the job template? For example, `IS_RELEASE`.
if [[ (${GITHUB_EVENT_NAME} = 'pull_request' && (${GITHUB_BASE_REF} = 'release'*)) || (${GITHUB_REF} = 'refs/heads/release'*) ]]; then
Expand Down
51 changes: 0 additions & 51 deletions .github/workflows/build-conda-linux.yml

This file was deleted.

52 changes: 0 additions & 52 deletions .github/workflows/build-conda-m1.yml

This file was deleted.

52 changes: 0 additions & 52 deletions .github/workflows/build-conda-macos.yml

This file was deleted.

50 changes: 0 additions & 50 deletions .github/workflows/build-wheels-linux.yml

This file was deleted.

51 changes: 0 additions & 51 deletions .github/workflows/build-wheels-m1.yml

This file was deleted.

51 changes: 0 additions & 51 deletions .github/workflows/build-wheels-macos.yml

This file was deleted.

Loading