Skip to content

Added allowed_workflows to pytorch probot #7485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/pytorch-probot.yml
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
tracking_issue: 2447

# List of workflows that will be re-run in case of failures
# https://github.com/pytorch/test-infra/blob/main/torchci/lib/bot/retryBot.ts
allowed_workflows:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment what this actually does? Preferably with a permalink to the implementation of the bot that uses this.

- Build Linux
- Build Macos
- Build M1
- Tests on Linux
- Tests on macOS
Comment on lines +6 to +10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are case-sensitive and basically just check job_name.startswith(allowed_workflow), shouldn't we be able to reduce this to

Suggested change
- Build Linux
- Build Macos
- Build M1
- Tests on Linux
- Tests on macOS
- Build
- Tests

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just prefer to be a bit more explicit. But again, this config should be maintained by domains. For now, I need it to be present. After, you can change it according to your needs or requirements.