-
Notifications
You must be signed in to change notification settings - Fork 7.1k
add smoke test for prototype namespace on release versions #7995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7995
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0b6c4c6 with merge base 1a9ff0d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip
I had another look and I'm not sure if the regex I used above is capturing everything. Our versions are all over the place:
*: Not sure what happened here. But this what I get with Since there is no rush for merging this before release, I suggest we wait after release to fill the blanks and revisit the regex. |
We use our version format as indicator for a release branch. On
main
we havevision/version.txt
Line 1 in 997384c
while on a release branch this is
vision/version.txt
Line 1 in fbb4cc5
Meaning, we only run the check if we find a
a0
after the regular semantic versioning.This should prevent #7983 in the future.
cc @bjuncek