Skip to content

add smoke test for prototype namespace on release versions #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 26, 2023

We use our version format as indicator for a release branch. On main we have

0.17.0a0

while on a release branch this is

0.16.0

Meaning, we only run the check if we find a a0 after the regular semantic versioning.

This should prevent #7983 in the future.

cc @bjuncek

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7995

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0b6c4c6 with merge base 1a9ff0d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip

@pmeier
Copy link
Collaborator Author

pmeier commented Sep 27, 2023

I had another look and I'm not sure if the regex I used above is capturing everything. Our versions are all over the place:

local build CI unittest CI
main 0.17.0a0+997384c 0.17.0.dev20230926+cpu 0.17.0a0+1a9ff0d
rc 0.16.0+a90e584 0.16.0+cpu 0.16.0+a90e584
release 0.15.2a0+fa99a53* 0.16.0+cpu 0.16.0+fbb4cc5

*: Not sure what happened here. But this what I get with git checkout v0.15.2 && python setup.py develop.

Since there is no rush for merging this before release, I suggest we wait after release to fill the blanks and revisit the regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants