Skip to content

Remove pinning of mpmath #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

Remove pinning of mpmath #8298

merged 1 commit into from
Mar 5, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Mar 5, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8298

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7a358dc with merge base fa5b844 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug marked this pull request as ready for review March 5, 2024 11:16
vfdev-5
vfdev-5 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@NicolasHug NicolasHug merged commit bca7a49 into pytorch:main Mar 5, 2024
@NicolasHug NicolasHug deleted the alfjenalefjnalfjen branch March 5, 2024 12:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug added module: ci other if you have no clue or if you will manually handle the PR in the release notes labels Mar 5, 2024
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 6, 2024

@NicolasHug maybe mpmath story is not fully resolved. Here is a run 06/03/2024 : https://github.com/pytorch/vision/actions/runs/8174594628/job/22349736355 but still failing with AttributeError: module 'mpmath' has no attribute 'rational'

@NicolasHug
Copy link
Member Author

Thanks for the heads up @vfdev-5 . Not sure why... let's see if #8310 could be a temporary fix

facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
@NicolasHug @facebook-github-bot
[fbsync] Remove pinning of mpmath (#8298)
87967f4 
Reviewed By: vmoens

Differential Revision: D55062765

fbshipit-source-id: e9f5d1ae2d15679b33145729813c76776455e43e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
cla signed module: ci other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All CI job are failing
3 participants
@NicolasHug @vfdev-5 @facebook-github-bot