Skip to content

Upgrade type hint and others to Python 3.9 #8814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

Upgrade type hint and others to Python 3.9 #8814

merged 3 commits into from
Apr 23, 2025

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Dec 15, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8814

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 1ec7215 with merge base 5515dff (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever force-pushed the ruff39 branch 2 times, most recently from 036a3da to b505aa5 Compare March 8, 2025 03:43
@AntoineSimoulin
Copy link
Member

Hey @cyyever, Thank you for submitting this PR! We're excited about the changes and would like to merge them into our codebase. However, it seems there are a some conflicts that need to be resolved before we can proceed. To streamline the process, I was wondering you could share your workflow and commands used to prepare this PR? This way, we can work together to resolve the conflicts and get the PR ready for merging.
Thanks!

@cyyever
Copy link
Contributor Author

cyyever commented Apr 22, 2025

@AntoineSimoulin Fixed

@cyyever cyyever marked this pull request as draft April 23, 2025 00:30
@cyyever cyyever force-pushed the ruff39 branch 2 times, most recently from 8229241 to 215752c Compare April 23, 2025 00:32
@NicolasHug NicolasHug marked this pull request as ready for review April 23, 2025 09:27
NicolasHug
NicolasHug approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cyyever !

@NicolasHug NicolasHug merged commit a095de1 into pytorch:main Apr 23, 2025
58 checks passed
@github-actions GitHub Actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @AntoineSimoulin @NicolasHug @facebook-github-bot