Fix docs build failure on Python 3.13+ by upgrading Sphinx#9506
Fix docs build failure on Python 3.13+ by upgrading Sphinx#9506Mikyx-1 wants to merge 2 commits into
Conversation
sphinx==5.0.0 imports `imghdr` via sphinx.util.images, a stdlib module removed in Python 3.13. Upgrading to sphinx>=7.0.0 removes this dependency. Fixes pytorch#9432
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9506
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Mikyx-1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
Fixes #9432.
docs/requirements.txtpinnedsphinx==5.0.0, which importsimghdrviasphinx.util.images. Theimghdrmodule was removed in Python 3.13, causing the docs build to fail immediately with:This PR upgrades the pin to
sphinx>=7.0.0, the first major version that removed theimghdrdependency.Changes
docs/requirements.txt:sphinx==5.0.0→sphinx>=7.0.0Test plan
sphinx==5.0.0make html-noplotcompletes successfully after the fix🤖 Generated with Claude Code