Skip to content

Commit 87fb0f3

Browse files
zhanyong-wanysiraichi
authored andcommitted
Revert "Ensure that all of PyTorch/XLA C++ is compiled with exceptions enabled. (#9146)"
This reverts commit 8450607.
1 parent 0f51780 commit 87fb0f3

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

.bazelrc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ build -c opt
2424

2525
build --config=short_logs
2626

27-
# PyTorch/XLA uses exceptions to communicate with Python.
28-
build --copt=-fexceptions
29-
3027
# Force GCC because clang/bazel has issues.
3128
build --action_env=CC=gcc
3229
build --action_env=CXX=g++

bazel/rules_def.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ def ptxla_cc_test(
2626
linkstatic = True,
2727
copts = copts + [
2828
"-isystemexternal/torch", # Required for system includes.
29+
"-fexceptions", # Required for testing crashes.
2930
],
3031
deps = deps + [
3132
"@pybind11//:pybind11_embed", # libpython

0 commit comments

Comments
 (0)