Skip to content

Ensure that all of PyTorch/XLA C++ is compiled with exceptions enabled. #9146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

zhanyong-wan
Copy link
Collaborator

@zhanyong-wan zhanyong-wan commented May 12, 2025

For #9145

Currently we only use -fexceptions for tests. We should use it for all C++ compilation to avoid undefined behavior.

#usability

@zhanyong-wan zhanyong-wan requested review from qihqi and tengyifei May 12, 2025 23:22
@zhanyong-wan zhanyong-wan enabled auto-merge (squash) May 12, 2025 23:23
@zhanyong-wan zhanyong-wan merged commit 8450607 into pytorch:master May 13, 2025
27 of 29 checks passed
lsy323 added a commit that referenced this pull request May 14, 2025
ysiraichi pushed a commit that referenced this pull request May 14, 2025
ysiraichi pushed a commit that referenced this pull request May 19, 2025
ysiraichi pushed a commit that referenced this pull request May 19, 2025
yaoshiang added a commit that referenced this pull request May 21, 2025
ysiraichi pushed a commit that referenced this pull request May 22, 2025
ghpvnist added a commit to ghpvnist/pytorch-xla that referenced this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants