Skip to content

Remove ParamSpec from pjrt.py to unblock nightly build #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Remove ParamSpec from pjrt.py to unblock nightly build #4037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions torch_xla/experimental/pjrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,7 @@
import os
import tempfile
from itertools import chain
from typing import Callable, Dict, Generic, List, Optional, Tuple, TypeVar

import sys
if sys.version_info < (3, 10):
from typing_extensions import ParamSpec, Concatenate
else:
from typing import ParamSpec, Concatenate
from typing import Callable, Dict, List, Optional, Tuple, TypeVar

import torch
import torch.distributed as dist
Expand All @@ -23,7 +17,6 @@
import torch_xla.utils.utils as xu
from torch_xla.experimental import tpu

P = ParamSpec('P')
R = TypeVar('R')
FN = TypeVar('FN')

Expand Down Expand Up @@ -198,8 +191,7 @@ def _thread_fn(device: torch.device):


@requires_pjrt
def _run_multiprocess(fn: Callable[P, R], *args: P.args,
**kwargs: P.kwargs) -> Dict[int, R]:
def _run_multiprocess(fn: Callable[..., R], *args, **kwargs) -> Dict[int, R]:
"""Runs `fn` on all devices available to PjRt.

Spawns one process per physical device (e.g. TPU chip).
Expand Down Expand Up @@ -237,8 +229,7 @@ def _run_multiprocess(fn: Callable[P, R], *args: P.args,
class _SpawnFn:
"""Pickle-able wrapper around `fn` that passes the ordinal before `args`"""

def __init__(self, fn: Callable[Concatenate[int, P], R], *args: P.args,
**kwargs: P.kwargs):
def __init__(self, fn: Callable[..., R], *args, **kwargs):
self.fn = fn
self.args = args
self.kwargs = kwargs
Expand Down