Support fullgraph for torch_xla.compile #7776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-cromar
approved these changes
Jul 30, 2024
| @@ -262,29 +262,36 @@ void DebugUtil::analyze_graph_execution_python_frame( | |||
|
|
|||
| static const std::string executation_output_prefix = "Execution Analysis: "; | |||
| static const std::string compilation_output_prefix = "Compilation Analysis: "; | |||
| static const std::string unexpected_execution_prefix = | |||
There was a problem hiding this comment.
micro-nit: should this be a constexpr std::string_view or constexpr char[] instead of a static const std::string?
| t2_compiled = torch_xla.compile( | ||
| self.dummy_graph_break, full_graph=True)( | ||
| t1) | ||
| self.assertIn( |
There was a problem hiding this comment.
assertRaisesRegex is what you want here https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaisesRegex
|
Let me merge it to unblock my other pr, I will fix review comment in a separate follow up pr too. |
JackCaoG
added a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with
torch_xla.compile(fn, full_graph=True)we will output an error message when we see graph breaks(early access of the value of tensor or cpu fallback) inside the passed infn