Skip to content

Switch bazel default spawn strategy to sandboxed #9168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

zhanyong-wan
Copy link
Collaborator

@zhanyong-wan zhanyong-wan commented May 14, 2025

For #9061.

Two reasons for this change:

  1. sandboxed is a better practice than standalone as it enforces explicit build dependency declaration.
  2. Compiling with Clang in standalone mode leads to an error. Clang works with the sandboxed mode.

If you use the dev container for developing PyTorch/XLA and you previously cloned the repo without world-readability, you may run into permission issues building PyTorch/XLA after this commit. To fix that, go to the workspace directory and run chmod -R o+rX .. This is also documented in .bazelrc.

basediff: #9156

@zhanyong-wan zhanyong-wan marked this pull request as draft May 14, 2025 18:19
@zhanyong-wan zhanyong-wan marked this pull request as ready for review May 14, 2025 20:57
@zhanyong-wan zhanyong-wan requested a review from qihqi May 14, 2025 20:57
@zhanyong-wan zhanyong-wan merged commit a9ba21c into pytorch:master May 15, 2025
29 checks passed
@zhanyong-wan zhanyong-wan deleted the clang3 branch May 15, 2025 14:30
zhanyong-wan added a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants