[torchax] Added support for bicubic and billinear resampling #9196
+242
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qihqi
reviewed
May 20, 2025
torchax/torchax/ops/jaten.py
Outdated
| size[1], | ||
| align_corners, | ||
| ) | ||
| return _aten_upsample( |
There was a problem hiding this comment.
same here, you want to raise OperatorNotFound so it will go through the old code path (and hopefully pass the tests in test_ops.py for interpolate.
There was a problem hiding this comment.
I tried it, it does not pass the test I built at torchax/test/test_image.py (torchax.tensor.OperatorNotFound: Operator with name aten::_upsample_bicubic2d_aa has no lowering) , so either I did something wrong building this test or I did something wrong building the operator
zmelumian972
force-pushed
the
torchax/image_resampling
branch
from
09f044d to
fa99f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently torchax does not support image resampling with antialiasing enabled
that, and the current implantation for bicubic resampling does not match torch
this PR aims to fix that