Error Handling: refactor the PjRt registry to use status QOL functions. #9419
+49
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
3 times, most recently
from
3302da5 to
50d9c5a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
5 times, most recently
from
9ebf41c to
8499caf
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
a4b9bd4 to
c0e7506
Compare
|
These CI failures seem to be coming from #9427. |
The CI should be fixed now. Could you rerun the checks and merge? |
Replace `XLA_CHECK` macros with `XLA_ASSIGN_OR_RETURN` and `XLA_RETURN_IF_ERROR` for better error handling: - `InitializePjRt()` now returns `StatusOr<T>` instead of throwing on errors - Enhanced error messages with location context - Consistent error handling across all device types
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
c0e7506 to
1f0dca3
Compare
|
I tried rerunning the CI, but the failures are still there. |
|
@bhavya01 , is this related to the fix you are working on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing
XLA_CHECK*macros withXLA_ASSIGN_OR_RETURNandXLA_RETURN_IF_ERRORfor improved error handling within the PyTorch/XLA codebase. Specifically, theInitializePjRt()function has been updated to returnStatusOr<T>.