Support editable install with setuptools>=80.0.0 #9428
Merged
+135
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR defaults the dev container to Python 3.12 because Python 3.10 is soon unusable with future JAX versions. Python 3.12 builds a package for editing in an isolated pip environment. That means we need a pyproject.toml file declaring which packages setup.py depends on, which is added in this PR. Also setup.py depends on torch to get the C++11 ABI status but that just won't work in Python 3.12 so that logic is adjusted accordingly. We need a bunch of other fixes due to the isolated environment change in Python 3.12. Finally, we need to add `12` into the list of Python versions when generating JAX dependencies. TEST: `scripts/build_developer.sh -a -t`
bhavya01
reviewed
Jul 1, 2025
tengyifei
changed the title
tengyifei
added a commit
that referenced
this pull request
Jul 2, 2025
Split out of #9428 Without this, we _definitely_ won't be able to use Pallas kernels on Python 3.12 This should also be cherry-picked into r2.8
bhavya01
approved these changes
Jul 10, 2025
bhavya01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setuptools>=80.0.0 relies on
python -m pip install -e .to build a package for editing in an isolated pip environment. That means we need a pyproject.toml file declaring which packages setup.py depends on, which is added in this PR.Also setup.py depends on torch to get the C++11 ABI status but that just won't work so that logic is adjusted accordingly. We need a bunch of other fixes due to the isolated environment.
TEST:
scripts/build_developer.sh -a -t