Error Handling: refactor ExecuteComputation
and ExecuteReplicated
to propagate status.
#9445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors both
ComputationClient:::ExecuteComputation
andComputationClient:::ExecuteReplicated
functions for propagating error statuses.Key Changes:
ExecuteComputation
andExecuteReplicated
: Now explicitly propagatesabsl::Status
..value()
Calls: UsesXLA_ASSIGN_OR_RETURN_WITH_LOCATION
for safer error handling.GetValueOrThrow
for more robust error management.Example:
Before this PR: no source code location
After this PR: source code location of the function call that raised this error