-
Notifications
You must be signed in to change notification settings - Fork 309
Implement FCI "Flames" fire visualisation #3129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 15437805336Details
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 429 429
Lines 57773 57808 +35
=======================================
+ Hits 55608 55643 +35
Misses 2165 2165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! I'm not an expert on stuff like this, but the images look cool and the code seems simple enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice (and surpisingly simple!) composite!
But is this a "spectral" composite comparable to SpectralBlender
and HybridGreen
composites? In #3123 (comment) I went through the currently existing compositors in composites.__init__.py
and tried to categorize them. From those (and the existing modules) I think this would go in the "other" category.
@@ -246,6 +246,57 @@ composites: | |||
- flash_age | |||
- true_color_with_night_ir105 | |||
|
|||
### True Color with Fires | |||
true_color_flames_with_night_ir105: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't there a recommendation from the RGB workshop to name all day-only products with a day
prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fire overlay works day&night, so also the background composite is day&night, so we can probably leave it like this? Naming of complex composites gets ugly quite quickly...
Co-authored-by: Panu Lahtinen <[email protected]>
I put it in spectral as it is using spectral tests, but yes indeed it doesn't fit well with the others. So I can move it to |
I moved the compositor to the init as suggested by Panu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion to fixe typos
This PR implements an FCI composite blending the True Color with a fire visualisation on top. To select the fire pixels to be colorised, a simple fire mask compositor is implemented.
WARNING: this is just a first attempt at this kidn of visualisation. The fire detector employed here is handcrafted, extremely simple and is prone to false alarms and missed detection. It is designed just for PR-like visualisations of larger fires and not for any other (operational fire detection) usage.
The implementation of the compositor is generic so that it can be used by other instruments after tuning the according parameters, although it has only been tested with FCI.
The parameters are tuned to be used with FDHSI+HRFI inputs (500m or 1km composite output)
Example code to generate an FCI image:
Some example images:




Portugal September 2024 wildfires:
Wildfires in southern Africa:
Attica Fire on 11.08.2024:
Etna Eruption on 04.08.2024: