CI: Update GHA runner to use ubuntu-22.04 #68
Conversation
WalkthroughThe GitHub Actions workflow configuration was updated to use Ubuntu 22.04 instead of Ubuntu 20.04 and to remove Python 3.6 from the test matrix, now supporting Python versions 3.7 through 3.13. No other workflow steps or environment variables were changed. Changes
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 4 4
Lines 320 320
Branches 67 58 -9
=======================================
Hits 308 308
Misses 7 7
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
.github/workflows/main.yml (1)
54-59: Dead code path: the Python 3.6 setup step is now unreachable – remove to declutter.The matrix no longer contains
3.6/pypy-3.6, so this step will never execute and only adds maintenance overhead.
Proposed cleanup:- - name: Set up project (Python 3.6) - if: matrix.python-version == '3.6' || matrix.python-version == 'pypy-3.6' - run: | - # Install requirements for testing. - pip install --requirement requirements-test.txt
🧹 Nitpick comments (1)
.github/workflows/main.yml (1)
60-74: Simplifyifguards now that 3.6 is gone.With 3.6 removed, the negated checks are redundant and can be dropped, improving readability:
- - name: Set up project (Python 3.7+) - if: matrix.python-version != '3.6' && matrix.python-version != 'pypy-3.6' + - name: Set up project- - name: Check code style - if: matrix.python-version != '3.6' && matrix.python-version != 'pypy-3.6' + - name: Check code style(All other logic inside the steps can stay unchanged.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main.yml(1 hunks)
🔇 Additional comments (2)
.github/workflows/main.yml (2)
25-25: Verify that all workflow steps are compatible withubuntu-22.04.Most open-source actions work fine, but a few (especially those pinning system packages) still assume
ubuntu-20.04.
Please re-run the workflow on a feature branch and double-check that:•
actions/setup-python@v5resolves every interpreter in the new matrix on 22.04.
• Third-party actions (Codecov, Poe, etc.) don’t pull in OS-specific binaries that were only built for 20.04.If anything breaks, consider pinning the affected job to
ubuntu-20.04until the action is patched.
26-34: All good: Python 3.13 is available in the Actions manifestA quick check of the
actions/python-versionsversions-manifest.jsonconfirms stable 3.13 releases (3.13.0 → 3.13.5) are published. No matrix adjustments needed—you can safely keep Python 3.13 in your workflow.
No description provided.