Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mathieuboudreau I opened this pull request to discuss about the Jupyter Notebook for the blog. First, I took a JN of the
qMRLab/t1_notebooks
project as a template and I customized it for the b1_afi method. I tested theActualFlipAngleImaging.ipynb
locally, the method and its functions to run the simulations are working, and the interactive plots were displayed with no problems.For Binder, I added
sos-r
,matplotlib
and I updated thesos
,sos-notebook
andplotly
to solve some Requirement.parse errors. I temporarily changed a couple of CLI instructions in theDockerfile
regarding git clone, as the branches b1_afi and blog_afi are not merged into master. However, an errorerror: 'b1_afi' undefined near line 7 column 16
is still occurring and I suspect it is about this git checkout in line 69, which I'm not sure how to solve it.https://github.com/jvelazquez-reyes/t1_notebooks/blob/blog_afi/Dockerfile#L65-L74