-
Notifications
You must be signed in to change notification settings - Fork 42
Delay parachain pre-compilation until the end of the sync #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- cmake/toolchain/flags/sanitize_address.cmake: Language not supported
turuslan
approved these changes
Apr 6, 2025
kamilsa
approved these changes
Apr 7, 2025
kamilsa
pushed a commit
that referenced
this pull request
Apr 9, 2025
* Delay parachain pre-compilation until the end of the sync * O0 runtime code optimization (cherry picked from commit 17c10cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
When precompilation starts immediately, before the node is synched, we don't know the parachain runtimes yet. So in this PR is delayed until we get them.
Also switch optimization to O0 temporarily because there's a weird runtime that's being compiled for hours on optimization levels higher than 0.
Possible Drawbacks
None expected from delay, somewhat slower runtime execution from O0.
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: