Skip to content

Delay parachain pre-compilation until the end of the sync #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 7, 2025

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Apr 3, 2025

Referenced issues

Description of the Change

When precompilation starts immediately, before the node is synched, we don't know the parachain runtimes yet. So in this PR is delayed until we get them.
Also switch optimization to O0 temporarily because there's a weird runtime that's being compiled for hours on optimization levels higher than 0.

Possible Drawbacks

None expected from delay, somewhat slower runtime execution from O0.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@kamilsa kamilsa requested a review from Copilot April 4, 2025 05:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • cmake/toolchain/flags/sanitize_address.cmake: Language not supported

@Harrm Harrm marked this pull request as ready for review April 4, 2025 14:58
@Harrm Harrm requested review from kamilsa and turuslan April 4, 2025 14:58
@Harrm Harrm merged commit 17c10cf into master Apr 7, 2025
13 checks passed
@Harrm Harrm deleted the fix/delay-precompilation branch April 7, 2025 10:59
kamilsa pushed a commit that referenced this pull request Apr 9, 2025
* Delay parachain pre-compilation until the end of the sync

* O0 runtime code optimization

(cherry picked from commit 17c10cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants