Skip to content

fix(config): sync validator with runtime schema#314

Merged
qhkm merged 1 commit intomainfrom
fix/config-validator-schema-sync-pr
Mar 11, 2026
Merged

fix(config): sync validator with runtime schema#314
qhkm merged 1 commit intomainfrom
fix/config-validator-schema-sync-pr

Conversation

@qhkm
Copy link
Copy Markdown
Owner

@qhkm qhkm commented Mar 10, 2026

Summary

  • accept top-level tunnel in config check
  • accept agents.defaults.timezone and agents.defaults.tool_timeout_secs
  • add a regression test for these valid fields
  • update AGENTS.md and CLAUDE.md with the validator/docs notes required by repo policy

Verification

  • cargo fmt -- --check
  • cargo clippy -- -D warnings
  • cargo run -- config check
    • result on /Users/dr.noranizaahmad/.zeptoclaw/config.json: 0 error(s), 2 warning(s)
  • cargo nextest run --lib could not run because cargo-nextest is not installed in this environment

Closes #310

Summary by CodeRabbit

  • Documentation

    • Added comprehensive documentation for configuration validation via zeptoclaw config check command, including tunnel and agent defaults.
    • Documented new environment variables for providers, agents, safety features, memory backends, and tooling.
  • New Features

    • Extended configuration validation to support tunnel settings and agent defaults (timezone, tool timeout).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d1318a2-d43b-4a5f-b5c5-4ebaa292d50e

📥 Commits

Reviewing files that changed from the base of the PR and between fb9006b and 609405b.

📒 Files selected for processing (3)
  • AGENTS.md
  • CLAUDE.md
  • src/config/validate.rs

📝 Walkthrough

Walkthrough

Sync the config validator with the schema by adding support for the tunnel top-level field and extending agent defaults recognition to include timezone and tool_timeout_secs. Documentation is updated to reflect these validated configuration options.

Changes

Cohort / File(s) Summary
Documentation Updates
AGENTS.md, CLAUDE.md
Add documentation for config validation via zeptoclaw config check command and new environment variables for agent defaults, providers, safety, memory, and other runtime settings.
Validator Logic
src/config/validate.rs
Extend validator to recognize tunnel as a top-level field and tool_timeout_secs and timezone as valid agent defaults. Add regression test confirming these previously-rejected fields are now accepted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The validator once rejected with a frown,
tunnel, timezone, tool_timeout too!
But now it knows what configs are true,
No more false flags in this config town!
🎉 Schemas and code finally align, it's true!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(config): sync validator with runtime schema' directly describes the main change—aligning the config validator with the runtime schema by accepting previously rejected fields.
Linked Issues check ✅ Passed The PR fully addresses issue #310 requirements: accepts top-level tunnel, agents.defaults.timezone, agents.defaults.tool_timeout_secs, updates validator allowlists, and adds regression test coverage.
Out of Scope Changes check ✅ Passed All changes directly support the core objective of syncing the validator with runtime schema; documentation updates in AGENTS.md and CLAUDE.md comply with repository policy and remain focused on the validator changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/config-validator-schema-sync-pr

Comment @coderabbitai help to get the list of available commands and usage tips.

@qhkm qhkm merged commit e7a3ea6 into main Mar 11, 2026
9 checks passed
@qhkm qhkm deleted the fix/config-validator-schema-sync-pr branch March 11, 2026 01:55
taqtiqa-mark pushed a commit to taqtiqa-mark/zeptoclaw that referenced this pull request Mar 25, 2026
## Summary
- accept top-level tunnel in config check
- accept agents.defaults.timezone and agents.defaults.tool_timeout_secs
- add a regression test for these valid fields
- update AGENTS.md and CLAUDE.md with the validator/docs notes required
by repo policy

## Verification
- cargo fmt -- --check
- cargo clippy -- -D warnings
- cargo run -- config check
- result on /Users/dr.noranizaahmad/.zeptoclaw/config.json: 0 error(s),
2 warning(s)
- cargo nextest run --lib could not run because cargo-nextest is not
installed in this environment

Closes qhkm#310

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Added comprehensive documentation for configuration validation via
`zeptoclaw config check` command, including tunnel and agent defaults.
* Documented new environment variables for providers, agents, safety
features, memory backends, and tooling.

* **New Features**
* Extended configuration validation to support tunnel settings and agent
defaults (timezone, tool timeout).

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: sync config validator with tunnel and agent defaults schema

1 participant