Conversation
sha2 0.11 migrated `digest` to v0.11 which switched the finalize() output
from `GenericArray` (impls `LowerHex`) to `hybrid-array::Array` (does not
impl `LowerHex`). Three call sites used `format!("{:x}", hasher.finalize())`
and broke the build.
Switched all three to the equivalent `hex::encode(hasher.finalize())` (we
already pull `hex` directly), preserving identical lowercase-hex output:
- src/cache/response_cache.rs:75
- src/security/pairing.rs:351
- src/cli/update.rs:172
Closes #517.
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe project upgraded the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
sha2 0.11 migrated `digest` to v0.11 which switched `finalize()` output from `GenericArray` (impls `LowerHex`) to `hybrid-array::Array` (does not impl `LowerHex`). Three call sites used `format!("{:x}", hasher.finalize())` and broke the build.
Switched all three to `hex::encode(hasher.finalize())` (we already pull the `hex` crate directly). Identical lowercase-hex output, no behavior change.
Sites
Validation
Closes #517.
🤖 Generated with Claude Code
Summary by CodeRabbit