chore(ci): expand CI matrix for optional integration features#548
chore(ci): expand CI matrix for optional integration features#548
Conversation
📝 WalkthroughWalkthroughThis PR expands the CI feature-matrix compilation to cover additional optional integration features (email channel, Google Workspace, Vertex provider, WhatsApp Web, and hardware/sandbox features) and fixes two latent compile-time issues that surface when these features are enabled: correcting async block variable reuse in the email channel task and resolving reqwest version incompatibility in the Google tool. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Cargo.toml (1)
49-50: Addhttp2to thereqwest013features for better Google API performance.Reqwest 0.13's default features include
http2, butdefault-features = falseremoves it from this declaration. The current feature set is valid for HTTP/1.1, but addinghttp2restores support for HTTP/2 multiplexing, which improves throughput for Gmail/Calendar batched requests at no cost.Optional: enable HTTP/2 for the Google client
-reqwest013 = { package = "reqwest", version = "0.13", features = ["json", "rustls", "stream", "multipart"], default-features = false, optional = true } +reqwest013 = { package = "reqwest", version = "0.13", features = ["json", "rustls", "http2", "stream", "multipart"], default-features = false, optional = true }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Cargo.toml` around lines 49 - 50, Update the reqwest013 dependency features to include "http2": in the Cargo.toml entry for the optional package alias reqwest013 (the line defining reqwest013 = { package = "reqwest", version = "0.13", features = [...], default-features = false, optional = true }), add "http2" to the features array so the reqwest 0.13 client enables HTTP/2 support for Google Workspace requests.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Cargo.toml`:
- Around line 49-50: Update the reqwest013 dependency features to include
"http2": in the Cargo.toml entry for the optional package alias reqwest013 (the
line defining reqwest013 = { package = "reqwest", version = "0.13", features =
[...], default-features = false, optional = true }), add "http2" to the features
array so the reqwest 0.13 client enables HTTP/2 support for Google Workspace
requests.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 82fdeeca-a942-40a6-8e14-7a6922a654c6
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
.github/workflows/ci.ymlAGENTS.mdCLAUDE.mdCargo.tomlsrc/channels/email_channel.rssrc/peripherals/i2c.rssrc/peripherals/mod.rssrc/peripherals/rpi_i2c.rssrc/peripherals/serial.rssrc/tools/google.rs
Summary
Cherry-pick of #544 (manelsen) under an author-owned branch — same OAuth `workflow` scope wall as #521/#542, resolved by SSH push.
Expands the CI feature-matrix to compile-check optional paths that previously drifted silently behind the default build:
`memory-embedding`, `screenshot`, `channel-email`, `google`, `provider-vertex`, `whatsapp-web`, `hardware`, `peripheral-rpi`, `probe`, `android`, `sandbox-landlock`, `sandbox-firejail`, `sandbox-bubblewrap`
The matrix expansion immediately surfaced two latent bugs that are also fixed here:
`google` feature also pulls a separate `reqwest013 = { package = "reqwest", version = "0.13" }` since the `gog-*` crates are still on reqwest 0.13 while main is on 0.12 — clean version-conflict workaround, only when `google` is enabled.
Closes #544.
Co-Authored-By: manelsen emanuelmoura@gmail.com
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Refactor
Tests