Skip to content

Conversation

@CarlJi
Copy link
Collaborator

@CarlJi CarlJi commented Aug 4, 2021

fix #201

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #212 (9b32247) into master (45aee23) will increase coverage by 2.91%.
The diff coverage is n/a.

❗ Current head 9b32247 differs from pull request most recent head 71d4f0f. Consider uploading reports for the commit 71d4f0f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   68.48%   71.39%   +2.91%     
==========================================
  Files          34       34              
  Lines        1745     2003     +258     
==========================================
+ Hits         1195     1430     +235     
- Misses        445      467      +22     
- Partials      105      106       +1     
Flag Coverage Δ
e2e-1.11.x ?
e2e-1.12.x ?
e2e-1.13.x ?
e2e-1.14.x ?
e2e-1.15.x ?
e2e-1.16.x ?
unittest-1.13.x 71.39% <ø> (+2.91%) ⬆️
unittest-1.14.x 71.29% <ø> (+2.81%) ⬆️
unittest-1.15.x 71.29% <ø> (+2.81%) ⬆️
unittest-1.16.x 71.29% <ø> (+2.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/commonflags.go 90.69% <0.00%> (-3.25%) ⬇️
pkg/cover/delta.go 87.09% <0.00%> (-2.27%) ⬇️
pkg/build/run.go 0.00% <0.00%> (ø)
pkg/qiniu/mock.go 100.00% <0.00%> (ø)
pkg/build/legacy.go 100.00% <0.00%> (ø)
pkg/build/gomodules.go 94.28% <0.00%> (+0.73%) ⬆️
pkg/qiniu/object.go 93.47% <0.00%> (+0.79%) ⬆️
pkg/cover/server.go 85.64% <0.00%> (+0.98%) ⬆️
pkg/cover/client.go 89.33% <0.00%> (+1.45%) ⬆️
cmd/merge.go 88.00% <0.00%> (+1.63%) ⬆️
... and 24 more

@CarlJi
Copy link
Collaborator Author

CarlJi commented Aug 4, 2021

/assign @lyyyuna

@lyyyuna
Copy link
Collaborator

lyyyuna commented Aug 6, 2021

/approve
/lgtm

@qiniu-bot qiniu-bot added the lgtm label Aug 6, 2021
@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CarlJi, lyyyuna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiniu-bot qiniu-bot merged commit e422a27 into qiniu:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is a vulnerability in gin v1.6.3,upgrade recommended

3 participants