Repository navigation
Support RuboCop 1.0 #262
Description
Last week, RuboCop shipped their 1.0 release: https://github.com/rubocop-hq/rubocop/releases/tag/v1.0.0
As this is a big milestone semver-wise, I think it makes sense to support 1.0 as the default RuboCop version for codeclimate. There will be no breaking changes in terms of introducing new cops for RuboCop until 2.0 ships.
More on that in the following blogpost by the maintainer: https://metaredux.com/posts/2020/10/21/rubocop-1-0.html
A good first step would be to add support for 1.0 in a release channel.
Reacted by William Weckl, Kevin Olbrich and Severin Schoepke
Metadata
Metadata
Assignees
Labels
No labels
Activity
britneywright commentedon Oct 29, 2020
Looks like 1.1.0 was released within the hour with some new cops https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#110-2020-10-29 maybe we should go straight to that.
britneywright commentedon Oct 29, 2020
Looks like there are some gems that have not yet released versions that are compatible with RuboCop >= 1.0.0
rubocop-i18nhas an open PR https://github.com/puppetlabs/rubocop-i18n/pull/46/filesrubocop-sequelThe rest of the gems seems to support upgrading, at least in terms of bundling.
wagenet commentedon Nov 12, 2020
rubocop-sequel has been updated, still waiting on rubocop-i18n
jsdalton commentedon Dec 14, 2020
Note: https://github.com/puppetlabs/rubocop-i18n has been archived. So I would presume codeclimate would either need to fork and modify or remove that dependency for this service in order to unblock this issue from being resolvable.
Not sure if any codeclimate employees are in this thread, but we're a bit frustrated that the rubocop plugin has fallen so far behind the current branch of Rubocop. This is one of our main use cases as customers.
ThomasKoppensteiner commentedon Dec 15, 2020
@jsdalton a few hours after your post the repo was unarchived. Now @highb takes care of it.
rubocop/rubocop-i18n#46 (comment)
imajes commentedon Dec 18, 2020
@britneywright can we take a look at this? It'd be really swell to get this updated for the 1.x versions :D
wagenet commentedon Jan 22, 2021
Rubocop 1.x is now supported. This can be closed.
imajes commentedon Jan 22, 2021
It would be good to actually add the 1.8.1 engine channel to codeclimate.com and change "rubocop-1.70" to "rubocop-1-7-1" to correctly match the channel name
sdrioux commentedon Jan 22, 2021
^ This.
This version is listed as a supported channel here: https://github.com/codeclimate/codeclimate-rubocop/branches/all?utf8=%E2%9C%93&query=channel%2Frubocop - but it looks like the latest version is 1.7.0. Is there something that needs to be done to add the 1.8.1 channel to codeclimate?
imajes commentedon Jan 26, 2021
@codeclimate @ale7714 @DanielWright -- thanks for getting the channel names correct, but where did you announce that? It'd be great if you could help by communicating too! :)
sdrioux commentedon Jan 26, 2021
Agreed - looks like 1.8.1 is now working as well, but would be great to be able to see that somewhere.
brandonrdn commentedon Jul 7, 2021
Hello all, I noticed a bunch of branches here for newer rubocop releases (i.e, 1-12-1, 1-18-3, etc) that haven't been "released" yet, as the newest available version for codeclimate is 1-9-1. I'm curious if there is an expected date to release these newer versions, or if there's anywhere to actively track progress on these. Thanks in advance.
mileslane commentedon Jul 12, 2021
I maintain our rubocop version for several different repositories and have yet to find any clear method for determining what rubocop channel will work. I always check here: https://docs.codeclimate.com/docs/rubocop and look for the most current channel. It would be extremely helpful if all the branches listed actually worked.
I am seeing this now:
WARNING: unknown engine <rubocop:rubocop-1-10-0>when runningcodeclimate engines:installWhy doesn't this list match the channel branches shown in the github repository?
f-moya commentedon Jul 13, 2021
@mileslane that's because the CLI hasn't been updated yet, will try to do that soon.