Skip to content

Support rubocop-sorbet alongside rubocop-airbnb #264

Open

Description

@bmulholland

Now that typechecking is coming in Ruby 3, sorbet will likely become more popular. https://github.com/shopify/rubocop-sorbet has some rubocop rules for sorbet that would be great to include.

Activity

  1. britneywright commented on Dec 1, 2020

    @britneywright

    @bmulholland Which version of rubocop are you using? sorbet is in supported in rubocop-0-92
    See #261

  2. bmulholland commented on Dec 1, 2020

    @bmulholland
    Author

    Huh, I definitely searched for sorbet in this repo before filing the issue. Not sure how I missed that!

    In any case, I'm unfortunately using the airbnb channel. Would you accept a PR to add sorbet to that channel?

  3. britneywright commented on Dec 1, 2020

    @britneywright

    You can try opening a PR. Keep in mind the airbnb plugin has some strict dependencies (https://rubygems.org/gems/rubocop-airbnb) that may make compatibility with other plugins difficult. That's why we had to make a separate channel to support it.

  4. bmulholland commented on Dec 2, 2020

    @bmulholland
    Author

    Yeah, great point. I upgraded gems on the rubocop-airbnb gem and submitted a PR - let's see if that unblocks things here.

  5. changed the title [-]Support rubocop-sorbet[/-] [+]Support rubocop-sorbet alongside rubocop-airbnb[/+] on Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions