Skip to content

Conversation

@waffle87
Copy link
Member

Description

Per this keyboard's SPI pins:

#define SPI_SCK_PIN GP22
#define SPI_MOSI_PIN GP23
#define SPI_MISO_PIN GP20

SPI1 is not the correct peripheral to be enabled:

image

This functioned correctly nonetheless because SPI0 is enabled by GENERIC_PROMICRO_RP2040.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 added the bug label Jul 12, 2025
@waffle87 waffle87 requested a review from a team July 12, 2025 03:28
@waffle87 waffle87 merged commit 86badb3 into qmk:master Jul 13, 2025
3 checks passed
@waffle87 waffle87 deleted the fix/bkb_dilemma_spi branch July 14, 2025 07:00
jcaliz pushed a commit to jcaliz/qmk_firmware that referenced this pull request Jul 27, 2025
tgdnt pushed a commit to tgdnt/qmk_firmware that referenced this pull request Aug 16, 2025
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Aug 20, 2025
Doc-Holmes pushed a commit to Doc-Holmes/qmk_firmware that referenced this pull request Aug 23, 2025
chrisjung01 pushed a commit to chrisjung01/qmk_firmware that referenced this pull request Sep 8, 2025
notchairmk pushed a commit to notchairmk/qmk_firmware that referenced this pull request Oct 24, 2025
itsme-zeix pushed a commit to itsme-zeix/qmk_firmware that referenced this pull request Oct 25, 2025
Paveun pushed a commit to Paveun/qmk_firmware that referenced this pull request Oct 31, 2025
coldwateryu pushed a commit to coldwateryu/qmk_firmware that referenced this pull request Nov 24, 2025
eth4nH pushed a commit to eth4nH/yunzii_firmware that referenced this pull request Dec 4, 2025
versality pushed a commit to versality/qmk_firmware that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants