-
Notifications
You must be signed in to change notification settings - Fork 38
Add generalized pauli operators (aka clock and shift matrices) #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 93.00% 93.03% +0.02%
==========================================
Files 25 26 +1
Lines 3104 3257 +153
==========================================
+ Hits 2887 3030 +143
- Misses 217 227 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Shouldn't these be methods of sigmax, sigmay, sigmaz instead? Should we implement them for FockBasis as well? If they are not methods of sigmax/y/z, should we implement them for SpinBasis(1//2)? |
78c3bc0 to
74d2433
Compare
|
There isn't a unique way to generalize the pauli operators as it depends on the properties one wants to preserve. Wikipedia has a nice overview.
Their implementation already generalizes them to arbitrary spin as the
I don't think so, since the generalization of clock and shift to a harmonic oscillator gives the cannonical position and momentum operators. In fact, historically it went the other way: Weyl used these matrices to give finite dimensional systems the same commutator as that of position and momentum in an oscillator.
Similarly to above, I would worry a bit about confusion. In my mind, the whole difference between a spin system and an N level system is that the angular momentum operators are actual physical operations. |
|
Could you add commentary to this effect in the docstring? And a |
Krastanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just adding a proper review to make my review queue a bit more organized
This is a great addition, thank you! To make it easier to navigate the difference between sigma* and pauli* could you add something based on your comments to the docstrings and add a see also that crossreferences between them.
We should also double check we are not breaking the documentation build now that we are exporting or crossreferencing new things.
74d2433 to
8081ac6
Compare
|
Thanks for the additions! Whenever you feel the new docs are ready, please feel free to merge / bump version / release. |
Closes #192