Fix rerender assertion when focussing certain Glimmer components#234
Merged
aoumiri merged 4 commits intoqonto:masterfrom Nov 15, 2021
Merged
Fix rerender assertion when focussing certain Glimmer components#234aoumiri merged 4 commits intoqonto:masterfrom
aoumiri merged 4 commits intoqonto:masterfrom
Conversation
nickschot
force-pushed
the
render-assertion-fix
branch
from
e461c19 to
7b8330c
Compare
nickschot
force-pushed
the
render-assertion-fix
branch
from
7b8330c to
cc97af2
Compare
|
LGTM, thanks for taking the time to do all this work 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rerender assertion would be triggered if we focus on a child where an
{{on "focus"}}modifier is present that modifies a tracked variable (see the added test case/minimal reproduction). This is not reproducible with a classic Ember component, hence the added devDependencies for Glimmer components/tracking.I think it would be good enough to only schedule
childElement.focus()on the next runloop rather than both cases, but we might want to keep things consistent, timing wise.The most notable practical application where the described issue occurs is ember-power-select.