Missing value information of an edge after onnx.shape_inference.infer_shapes(model) which causes failing GAP test

[cjm715]

the required version of onnx==1.16 fails to provide value information for an edge after quantizeLinear after shape inference from the call model = onnx.shape_inference.infer_shapes(model) within the function check_qtype_by_node_type. This eventually leads to an assert error since this information is needed to check expected types. This is resolved in onnx==1.17. However, the current version of onnxruntime has limited support for onnx==1.17 and its default opset.

[cjm715]

QLinearGlobalAveragePool is in microsoft.com domain. I wonder if that's the reason we are seeing issues with shape inference given comment?
https://github.com/Microsoft/onnxruntime/blob/main/onnxruntime/test/python/quantization/op_test_utils.py#L626-L629 cc: @ndrego

[cjm715]

left is initial graph , right is after shape inference on onnx. shape inference pass is able to infer output of the first quantizeLinear but not the second one (which leads to the error). Also QLinearGlobalAveragePool nodes get modified (argument names change and module changes from com.microsoft v1 to ai.onnx)

[cjm715]

setting onnx==1.16 in requirement by default will install onnx==1.16.0. By explicitly stating minor version like so onnx==1.16.2 , shape inference is able to infer edge of interest and test passes.

with 1.16.2, we see this after shape inference on quantize graph under test:

[cjm715]

This was an issue with a bug with shape inference in 1.16.0. This was fixed here: onnx/onnx#6049

As stated in description "If shape-inference encounters a custom-op, inference results are not updated for subsequent nodes."

Since QLinearAveragePool is a custom op (outside of onnx) , subsequent nodes were not updated rather than just skipped. PR fixes this.

Thus, we only need these 2 prs to support ort v23 transistion:

https://github.com/quadric-io/tvm/pull/1845
https://github.com/quadric-io/sdk-cli/pull/786