Fix mainline branch builds to not require changes for mainline movements#216
Closed
basak-qcom wants to merge 1 commit intomainfrom
Closed
Fix mainline branch builds to not require changes for mainline movements#216basak-qcom wants to merge 1 commit intomainfrom
basak-qcom wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Robie Basak <robie.basak@oss.qualcomm.com>
Contributor
|
What you proposed would work and would be an improvement Personally, I wanted to have the linux-image packages coming from mainline builds be named something different, like linux-image-upstream- or linux-image-mainline- and then use apt pattern matching to select that. I think it would be more natural to read, but I didn't get to it. |
basak-qcom
added a commit
to basak-qcom/qcom-deb-images
that referenced
this pull request
Jan 5, 2026
Add support to request the automatic detection and use of the kernel matching the pattern linux-image-* that is present in the local directory of extra debs, and use this from the linux.yml workflow. This saves us having to manually keep linux.yml in sync with the latest upstream tag. Discussion in qualcomm-linux#216 Signed-off-by: Robie Basak <robie.basak@oss.qualcomm.com>
Contributor
|
We merged a newer version of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion. Would this make commits like 84989c2 unnecessary? I used this repository rather than my own in order to run the workflow (including a hack to turn off the
mainbranch checker). Results: https://github.com/qualcomm-linux/qcom-deb-images/actions/runs/20339660861Is this a reasonable approach to the general problem, or am I missing something? If the former, I can clean up.