Skip to content

ENH: upgrade pandas to 0.19.2 #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ENH: upgrade pandas to 0.19.2 #1775

wants to merge 1 commit into from

Conversation

kennell
Copy link

@kennell kennell commented Apr 30, 2017

Hi folks. This upgrades Pandas to version 0.19.2 and fixes some issues dealing with the pickle'd output when using Python 3.6, see pandas-dev/pandas#14679 for details on the issue.

@kennell kennell changed the title Dependencies: upgrade to pandas to 19.2 ENH: upgrade pandas to 19.2 May 1, 2017
@kennell kennell changed the title ENH: upgrade pandas to 19.2 ENH: upgrade pandas to 0.19.2 May 1, 2017
@kennell
Copy link
Author

kennell commented May 28, 2017

Folks, any chance we can get this merged? Regarding the travis test, perhaps someone can re-trigger.

@richafrank
Copy link
Member

Hey @kennell , could you tell us more about what this fixes?

I see two changes here:

  1. The first increments the lower bound of required pandas versions, which I don't think we want to do. The quantopian platform on the website is running zipline with the lower pandas version, so we very much want to support that version right now.
  2. The second increments the upper bound of support, which I don't have a strong opinion on, assuming zipline works. It looks like travis and appveyor are running tests only with the lower bound version, so could you update the test matrix to assess both the lower and upper? I believe @ssanderson last bumped that upper bound, so probably he could share how he chose the version listed on master.

Thanks!

@richafrank
Copy link
Member

Folks, any chance we can get this merged? Regarding the travis test, perhaps someone can re-trigger.

Travis doesn't seem to know about that build, so there's nothing I can re-run. Want to update your branch to trigger a new run?

@Peque
Copy link
Contributor

Peque commented Jun 1, 2017

Note that you may need to update some other files (see #1810).

Also, I would rather set 'pandas': '<0.20' for the upper bounds, to allow future minor versions, which could fix bugs but should not break compatibility.

@freddiev4
Copy link
Contributor

freddiev4 commented Oct 3, 2017

Going to close this due to inactivity/no response from OP. Feel free to re-open or open a new PR 🙂

@freddiev4 freddiev4 closed this Oct 3, 2017
@Peque
Copy link
Contributor

Peque commented Oct 4, 2017

Created #1975 for those who wish to subscribe/comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants