Skip to content

Pin sympy version to <1.10#5059

Merged
95-martin-orion merged 2 commits intomasterfrom
sympy-pin
Mar 7, 2022
Merged

Pin sympy version to <1.10#5059
95-martin-orion merged 2 commits intomasterfrom
sympy-pin

Conversation

@95-martin-orion
Copy link
Copy Markdown
Collaborator

Part of #5058. The latest sympy release (v1.10) appears to have broken our mypy tests: #4936, #4964, #5030

Pinning until we can bring ourselves up to date (assuming that's what we want to do here)

@95-martin-orion 95-martin-orion requested review from a team, cduck and vtomole as code owners March 7, 2022 18:17
@CirqBot CirqBot added the Size: XS <10 lines changed label Mar 7, 2022
Copy link
Copy Markdown
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread cirq-core/requirements.txt Outdated
sortedcontainers~=2.0
scipy
sympy
sympy==1.9
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link the bug to fix type errors here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vtomole
Copy link
Copy Markdown
Collaborator

vtomole commented Mar 7, 2022

Would loosening the requirements (sympy<1.10) give any benefits?

@mpharrigan
Copy link
Copy Markdown
Collaborator

pleeeeeeease no ==. If <1.10 fixes, then consider doing that

@mpharrigan
Copy link
Copy Markdown
Collaborator

any time you use == in install_requires with pip's new dependency resolver it can easily cause unsolvable dependency conflicts. As always, I will point out that you're supposed to pin in requirements.txt for CI but relax in install_requires for user consumption, but they are linked in our build

@95-martin-orion
Copy link
Copy Markdown
Collaborator Author

Changed to sympy<1.10.

@95-martin-orion 95-martin-orion changed the title Pin sympy version to 1.9 Pin sympy version to <1.10 Mar 7, 2022
@95-martin-orion 95-martin-orion merged commit 3cdf896 into master Mar 7, 2022
@95-martin-orion 95-martin-orion deleted the sympy-pin branch March 7, 2022 18:56
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Pin sympy version to 1.9

* Loosen requirements
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
* Pin sympy version to 1.9

* Loosen requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants