Format all code with latest black version and config#5258
Closed
Format all code with latest black version and config#5258
Conversation
maffoo
requested review from
a team,
ColemanCollins,
HGSilveri,
cduck,
dabacon,
gmauricio,
ma5x,
mrwojtek,
nakardo,
pschindler and
vtomole
as code owners
Collaborator
|
Did you check for matrix formatting? I have a PR in flight that keeps many of the matrix cases formatted in a more readable form. |
Collaborator
|
#5259 has matrix format preserving where I could find it. I wonder why we have different file counts? |
Contributor
Author
|
I'm happy to close this and defer to #5259. |
Contributor
Author
|
Closing in favor of #5259. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This formats all code files with the latest black version (see #5157) and options (see #5170). The main formatting difference from the version bump is to remove whitespace around the
**operator, which generally matches hand-written style and makes precedence more clear. Theskip-magic-trailing-commaoption makes formatting more deterministic and generally reduces vertical space (here we remove ~6000 lines altogether). Doing this in one commit ensures that logic changes to these modules will not be mixed in with formatting changes. Once this is merged we will add the commit hash to.git-blame-ignore-revsto ensure this doesn't obscure the history as seen bygit blame.